This repository was archived by the owner on May 2, 2022. It is now read-only.
Cleanup previous bundles #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
Closed
calavera
approved these changes
Sep 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48.
This removes any previous bundles in
.netlify/edge-handlers/before writing a new bundle.The intention is for cleanup purposes, i.e. to ensure that directory does not grow too large with time.
One potential problem would be if Edge handlers have been bundled and are being uploaded, and another process is bundling them again, in which case this would make the upload file. However, I don't think this situation can arise for us, but please let me know if such a race condition (or any other problem) could happen. Thanks!