Improve error handling of Rollup #75
Conversation
| }); | ||
| return code; | ||
| } catch (error) { | ||
| return utils.build.failBuild("Error while bundling Edge handlers", { error }); |
There was a problem hiding this comment.
will this still throw? what will the return value of the function become? don't we have to cancel upstream steps somehow?
There was a problem hiding this comment.
From a plugin authoring standpoint, the execution will stop right there. The return is actually not needed (and it could be removed).
The way this is implemented under the hood is by throwing an error.
Rollup should stop since it just failed. Also, uploading has not started yet. The build will stop, which should prevent anything else to be run. Is there something specific you had in mind that should be cancelled?
There was a problem hiding this comment.
i just wanted to make sure we don't continue uploading empty code when returning here
There was a problem hiding this comment.
can you add a comment that calling this actually throws and thereby stops execution?
ehmicky
force-pushed
the
bug/error-handle-rollup
branch
from
b58acec to
7bcf5b0
Compare
Fixes #69.
If a Edge handler source file has a syntax error, Rollup will fail.
This should be handled and reported as a user error (using
utils.build.failBuild()) instead of a plugin error.