Skip to content
This repository was archived by the owner on May 2, 2022. It is now read-only.

Compact bundle #76

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Compact bundle #76

merged 1 commit into from
Sep 25, 2020

Conversation

@ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Sep 25, 2020

Part of #73.

This uses the compact option of Rollup.

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 25, 2020
@ehmicky ehmicky self-assigned this Sep 25, 2020
@ehmicky ehmicky mentioned this pull request Sep 25, 2020
Closed
mraerino
mraerino approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to be aware that it only minifies the rollup boilerplate, not the handler code itself

@ehmicky ehmicky merged commit 33e2a6c into master Sep 25, 2020
@ehmicky ehmicky deleted the feat/minify branch September 25, 2020 16:13
@shortdiv shortdiv mentioned this pull request Sep 25, 2020
Merged
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@calavera calavera Awaiting requested review from calavera

@shortdiv shortdiv Awaiting requested review from shortdiv

1 more reviewer

@mraerino mraerino mraerino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ehmicky ehmicky

Labels

type: feature code contributing to the implementation of a feature and/or user facing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehmicky @mraerino