Skip to content

fix: update html-minifier to be html-minifier-terser to solve vulnerability #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
+135 −66
Merged

fix: update html-minifier to be html-minifier-terser to solve vulnerability #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"compression": "^1.7.4",
"dotenv": "^16.0.0",
"express": "^4.17.1",
"html-minifier": "^4.0.0",
"html-minifier-terser": "^7.2.0",
"lighthouse": "^9.6.3",
"puppeteer": "^24.8.2"
},
Expand Down
6 changes: 3 additions & 3 deletions src/format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import chalk from 'chalk';
import { minify } from 'html-minifier';
import { minify } from 'html-minifier-terser';

import makeReplacements from './replacements.js';

Expand Down Expand Up @@ -40,7 +40,7 @@ export const formatShortSummary = (categories) => {
.join(', ');
};

export const formatResults = ({ results, thresholds }) => {
export const formatResults = async ({ results, thresholds }) => {
const runtimeError = results.lhr.runtimeError;

const categories = Object.values(results.lhr.categories).map(
Expand Down Expand Up @@ -71,7 +71,7 @@ export const formatResults = ({ results, thresholds }) => {
const installable = results.lhr.audits['installable-manifest']?.score === 1;
const details = { installable, formFactor, locale };

const report = minify(formattedReport, {
const report = await minify(formattedReport, {
removeAttributeQuotes: true,
collapseWhitespace: true,
removeRedundantAttributes: true,
Expand Down
18 changes: 10 additions & 8 deletions src/format.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,10 @@ describe('format', () => {
report: '<!doctype html>\n' + '<html lang="en">Hi</html>\n',
});

it('should return formatted results', () => {
expect(formatResults({ results: getResults(), thresholds: {} })).toEqual({
it('should return formatted results', async () => {
expect(
await formatResults({ results: getResults(), thresholds: {} }),
).toEqual({
details: {
formFactor: undefined,
installable: false,
Expand All @@ -154,11 +156,11 @@ describe('format', () => {
});
});

it('should return formatted results with passing thresholds', () => {
it('should return formatted results with passing thresholds', async () => {
const thresholds = {
performance: 0.1,
};
const formattedResults = formatResults({
const formattedResults = await formatResults({
results: getResults(),
thresholds,
});
Expand All @@ -173,11 +175,11 @@ describe('format', () => {
]);
});

it('should return formatted results with failing thresholds', () => {
it('should return formatted results with failing thresholds', async () => {
const thresholds = {
performance: 1,
};
const formattedResults = formatResults({
const formattedResults = await formatResults({
results: getResults(),
thresholds,
});
Expand All @@ -197,7 +199,7 @@ describe('format', () => {
]);
});

it('should use supplied config settings and data to populate `details`', () => {
it('should use supplied config settings and data to populate `details`', async () => {
const results = getResults();
results.lhr.configSettings = {
locale: 'es',
Expand All @@ -208,7 +210,7 @@ describe('format', () => {
score: 1,
};

const formattedResults = formatResults({ results, thresholds: {} });
const formattedResults = await formatResults({ results, thresholds: {} });
expect(formattedResults.details).toEqual({
formFactor: 'desktop',
installable: true,
Expand Down
2 changes: 1 addition & 1 deletion src/lib/run-audit-with-server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const runAuditWithServer = async ({
return { error };
} else {
const { summary, shortSummary, details, report, errors, runtimeError } =
formatResults({
await formatResults({
results,
thresholds,
});
Expand Down
2 changes: 1 addition & 1 deletion src/lib/run-audit-with-url/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const runAuditWithUrl = async ({ path = '', url, thresholds, settings }) => {
return { error };
} else {
const { summary, shortSummary, details, report, errors, runtimeError } =
formatResults({
await formatResults({
results,
thresholds,
});
Expand Down
Loading
Loading