Skip to content

Conversation

@colbyfayock
Copy link
Contributor

@colbyfayock colbyfayock commented Jun 18, 2021

Updates the version of the netlify-plugin-visual-diff along with compatibility.

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Test plan

https://app.netlify.com/sites/erez-applitools-test/deploys/60d20b3425ba790008c8b81e#L95
https://app.netlify.com/sites/erez-applitools-test/deploys/60d20bd225ba790008c9058d#L81

@netlify-bot
Copy link
Collaborator

netlify-bot commented Jun 18, 2021

@erezrokah erezrokah added the type: bug code to address defects in shipped code label Jun 22, 2021
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @colbyfayock,
See applitools/netlify-plugin-visual-diff#8 (comment) for the cause of the CI failure.
Also see

"compatibility": [
for an example.

@ehmicky ehmicky changed the title Update netlify-plugin-visual-diff to 1.5.0 feat: update netlify-plugin-visual-diff to 1.5.0 Jun 22, 2021
@colbyfayock
Copy link
Contributor Author

thanks @ehmicky @erezrokah made the tweaks, lmk if you need anyhting else

Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo @colbyfayock, looking good.

I have one last issue about the versions I'd like to understand better

@colbyfayock
Copy link
Contributor Author

colbyfayock commented Jun 22, 2021

thanks @erezrokah was able to deprecate 1.4.0 and 1.4.1 as well as updating the compat

@erezrokah erezrokah changed the title feat: update netlify-plugin-visual-diff to 1.5.0 feat: update netlify-plugin-visual-diff to 1.3.0 and 2.0.0 Jun 22, 2021
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @colbyfayock !

@ehmicky ehmicky enabled auto-merge (squash) June 22, 2021 13:44
@ehmicky ehmicky requested a review from erezrokah June 22, 2021 13:44
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colbyfayock, sorry for the delay to merge.

I updated the PR with 2 distinct build logs for versions 1.3.0 and 2.0.0

@ehmicky ehmicky merged commit bdd8c5a into netlify:main Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug code to address defects in shipped code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants