From 9738c88247408c4311e61a85ba1598a14b9156f2 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Fri, 14 Nov 2025 14:33:03 +0000 Subject: [PATCH 1/3] Add Node.js 24 support to CI and package Co-authored-by: philippe.serhal --- .github/workflows/test.yaml | 5 ++++- packages/vite-plugin-tanstack-start/package.json | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 7eb92884..6cb80e0c 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -23,6 +23,9 @@ jobs: # But there is a blocking bug in 20.6.0, fixed in 20.6.1: # https://github.com/nuxt/nuxt/issues/23020#issuecomment-1719828889 node-version: '20.6.1' + - os: ubuntu-latest + # Explicitly test the latest major release. + node-version: '24' fail-fast: false steps: # Increasing the maximum number of open files. See: @@ -42,7 +45,7 @@ jobs: # Use npm@10 on Node 22+ due to https://github.com/npm/cli/issues/8489 - name: Setup npm version run: npm install -g npm@10 - if: "${{ matrix.node-version == '*' }}" + if: "${{ matrix.node-version == '*' || matrix.node-version == '24' }}" - name: Setup Deno uses: denoland/setup-deno@v1 with: diff --git a/packages/vite-plugin-tanstack-start/package.json b/packages/vite-plugin-tanstack-start/package.json index cc4b83fc..3194298b 100644 --- a/packages/vite-plugin-tanstack-start/package.json +++ b/packages/vite-plugin-tanstack-start/package.json @@ -4,7 +4,7 @@ "description": "Vite plugin for TanStack Start on Netlify", "type": "module", "engines": { - "node": "^22.12.0" + "node": "^22.12.0 || >=24.0.0" }, "main": "./dist/main.js", "exports": "./dist/main.js", From 802f6263df883f4de1a129906514062749098b07 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Fri, 14 Nov 2025 14:46:37 +0000 Subject: [PATCH 2/3] Update test workflow to use Node 24 Co-authored-by: philippe.serhal --- .github/workflows/test.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 6cb80e0c..9ff1a890 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -16,7 +16,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - node-version: ['*'] + node-version: ['24'] include: - os: ubuntu-latest # Many of our dependencies require 20.6.0, so we use the same minimum. @@ -45,7 +45,7 @@ jobs: # Use npm@10 on Node 22+ due to https://github.com/npm/cli/issues/8489 - name: Setup npm version run: npm install -g npm@10 - if: "${{ matrix.node-version == '*' || matrix.node-version == '24' }}" + if: "${{ matrix.node-version == '24' }}" - name: Setup Deno uses: denoland/setup-deno@v1 with: From 1b0aa6aa37e5af90c4057703d0a3598ffa9271ee Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Fri, 14 Nov 2025 17:13:24 +0000 Subject: [PATCH 3/3] Remove node 24 from test workflow Co-authored-by: philippe.serhal --- .github/workflows/test.yaml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 9ff1a890..14d0adc2 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -23,9 +23,6 @@ jobs: # But there is a blocking bug in 20.6.0, fixed in 20.6.1: # https://github.com/nuxt/nuxt/issues/23020#issuecomment-1719828889 node-version: '20.6.1' - - os: ubuntu-latest - # Explicitly test the latest major release. - node-version: '24' fail-fast: false steps: # Increasing the maximum number of open files. See: