Skip to content

Conversation

@jpinsonneau
Copy link
Contributor

Here is a non exhaustive list of errors with related tweaks you may apply.

We can try to better define some default values according to cluster sizes or flow processed per second in a table format in followup.

@jpinsonneau jpinsonneau requested review from jotak and memodi December 6, 2022 12:08
@memodi
Copy link
Member

memodi commented Dec 6, 2022

/cc @nathan-weinberg

LGTM

@nathan-weinberg
Copy link
Contributor

Thanks for this @jpinsonneau - please add details as to how/where to change these configs (i.e. the kubectl or oc commands) as well

@eranra
Copy link
Contributor

eranra commented Dec 6, 2022

@nathan-weinberg this answers a lot of the questions around (run without limits)

@jpinsonneau this is great info

@eranra
Copy link
Contributor

eranra commented Dec 6, 2022

@jpinsonneau what about automation of all of those ... can we somehow "do" that --- maybe create a script to run over the operator that we add in the instructions for customers?

@jpinsonneau
Copy link
Contributor Author

@jpinsonneau what about automation of all of those ... can we somehow "do" that --- maybe create a script to run over the operator that we add in the instructions for customers?

For loki simple / distributed it's easy to integrate these in the provided config. I'll double check these but we are in a good shape for now.
We decided to take more time for loki-operator as it needs parameters defined in their CRD. I wonder if we can do something more flexible to allow any config without having a huge CRD on their side.

@jpinsonneau
Copy link
Contributor Author

Thanks for this @jpinsonneau - please add details as to how/where to change these configs (i.e. the kubectl or oc commands) as well

Sure I can document this for each situations: simple / distributed / loki-operator

@jpinsonneau
Copy link
Contributor Author

Thanks for this @jpinsonneau - please add details as to how/where to change these configs (i.e. the kubectl or oc commands) as well

Here we go dee092b @nathan-weinberg

Copy link
Contributor

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jpinsonneau jpinsonneau merged commit 3055da2 into netobserv:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants