Skip to content

Conversation

@tkuldeep
Copy link
Contributor

@tkuldeep tkuldeep commented Jun 28, 2022

In this pr I have just fixed network definition for aggregate destination connection count
Fixes #242

@KalmanMeth
Copy link
Collaborator

@ronensc Please take a look.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2022

Codecov Report

Merging #244 (608891e) into main (24bcbf2) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
+ Coverage   61.19%   61.39%   +0.20%     
==========================================
  Files          67       67              
  Lines        3860     3888      +28     
==========================================
+ Hits         2362     2387      +25     
- Misses       1348     1349       +1     
- Partials      150      152       +2     
Flag Coverage Δ
unittests 61.39% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/pipeline/ingest/ingest_kafka.go 80.15% <0.00%> (-0.43%) ⬇️
pkg/pipeline/transform/transform_filter.go 94.59% <0.00%> (+0.15%) ⬆️
pkg/pipeline/transform/transform_network.go 61.07% <0.00%> (+0.26%) ⬆️
pkg/pipeline/decode/decode_json.go 92.00% <0.00%> (+1.09%) ⬆️
pkg/pipeline/ingest/ingest_collector.go 49.61% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bcbf2...608891e. Read the comment docs.

Copy link
Contributor

@ronensc ronensc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkuldeep Good catch!
Please run make generate-configuration to update the docs.

@tkuldeep
Copy link
Contributor Author

@ronensc Updated flp configuration docs with latest changes. please have a look.

@ronensc ronensc merged commit 09081e2 into netobserv:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix network definition for aggregate destination connection count

4 participants