Remove unnecessary goroutine of loki writer #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 69.00% 68.99% -0.01%
==========================================
Files 86 86
Lines 4900 4889 -11
==========================================
- Hits 3381 3373 -8
+ Misses 1306 1303 -3
Partials 213 213
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mariomac
approved these changes
Oct 18, 2022
ronensc
approved these changes
Oct 18, 2022
jotak
requested changes
Oct 19, 2022
Member
jotak
left a comment
jotak
left a comment
There was a problem hiding this comment.
L256 there's this comment that I wrote: // TODO / FIXME / FIGUREOUT bla bla => it should be removed, as well as the channel creation and the associated gauge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loki write use a goroutine to do async send to loki.
This is unnecessary because loki client is already doing async send.
I tested this change under some load and did not see any impact.