Skip to content

fix(refs): address Copilot review followups from #53/#54/#55#56

Merged
CybotTM merged 1 commit into
mainfrom
fix/copilot-review-followups
Apr 21, 2026
Merged

fix(refs): address Copilot review followups from #53/#54/#55#56
CybotTM merged 1 commit into
mainfrom
fix/copilot-review-followups

Conversation

@CybotTM
Copy link
Copy Markdown
Member

@CybotTM CybotTM commented Apr 21, 2026

Follow-up to Copilot review comments on the three recently-merged reference PRs:

Changes

workflow-bash-patterns.md (#53):

  • Clarify that fetch-depth: 0 in actions/checkout means full history (not shallow); use fetch-depth: 1 as the example of a shallow clone
  • Rephrase the pipefail/SIGPIPE description — the example shows a pipeline, not an if, so the outcome is 'step fails' rather than 'if evaluates as false'

auto-merge-guide.md (#54):

  • Bump reviewThreads(first: 50 -> 100) to GitHub's per-page maximum so the sweep doesn't silently miss threads on PRs with >50 threads
  • Note that comments(first: 1) only returns the initiating comment (reply context needs higher first: or pagination)
  • Fix link-text/href mismatch in the review-reply mutation pointer

merge-strategy.md (#55):

  • Include requested_teams alongside requested_reviewers in the pending-review status check so team review requests are counted too

Thread IDs resolved after merge

- workflow-bash-patterns.md: clarify fetch-depth=0 means full history;
  rephrase pipefail/SIGPIPE description (step fails, not 'if evaluates
  as false', since no if is shown in the example)
- auto-merge-guide.md: bump reviewThreads(first: 50 -> 100) to match
  GitHub's page limit; clarify comments(first: 1) only fetches the
  initiating comment; fix link-text/href mismatch
- merge-strategy.md: include requested_teams alongside requested_reviewers
  so the pending-reviewer check catches team requests too

Threads:
- #53: PRRT_kwDOQoDmGs58Zoh5, PRRT_kwDOQoDmGs58ZoiH
- #54: PRRT_kwDOQoDmGs58ZrK7, PRRT_kwDOQoDmGs58ZrLJ, PRRT_kwDOQoDmGs58ZrLW
- #55: PRRT_kwDOQoDmGs58Z7Uh

Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Copilot AI review requested due to automatic review settings April 21, 2026 17:39
@CybotTM CybotTM merged commit c283b02 into main Apr 21, 2026
10 checks passed
@CybotTM CybotTM deleted the fix/copilot-review-followups branch April 21, 2026 17:40
@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Follow-up documentation fixes across GitHub Project skill references to address review feedback from recently merged PRs (#53/#54/#55), improving correctness of examples and clarifying GitHub API/Actions behavior.

Changes:

  • Clarifies actions/checkout fetch-depth semantics and refines the pipefail/SIGPIPE explanation in the workflow bash patterns reference.
  • Updates the post-merge review sweep GraphQL examples to use reviewThreads(first: 100) and clarifies limitations of comments(first: 1) plus a link fix.
  • Updates the “pending review” workaround example to count both user and team review requests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
skills/github-project/references/workflow-bash-patterns.md Clarifies fetch-depth meaning and improves the pipefail/SIGPIPE narrative to match the example’s behavior.
skills/github-project/references/auto-merge-guide.md Raises review thread page size to 100 and clarifies thread/comment retrieval limitations plus fixes a reference link.
skills/github-project/references/merge-strategy.md Expands the pending-review check example to include requested_teams alongside requested_reviewers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/github-project/references/merge-strategy.md
Comment thread skills/github-project/references/auto-merge-guide.md
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates documentation and scripts related to GitHub automation and bash patterns. Key updates include increasing the GraphQL thread limit in the auto-merge guide, refining the pending reviewer check to include teams and handle null values, and correcting documentation regarding fetch-depth and shell pipeline behavior. I have no feedback to provide.

CybotTM added a commit that referenced this pull request Apr 21, 2026
fix(refs): address Copilot second-sweep findings from #56
@CybotTM CybotTM mentioned this pull request May 15, 2026
CybotTM added a commit that referenced this pull request May 15, 2026
## Release v2.14.0

Minor release. `.claude-plugin/plugin.json` and
`skills/github-project/SKILL.md` frontmatter `metadata.version` were
already synced to `2.14.0` on `main` via
[#74](#74) —
this PR is the empty release marker that closes the v2.13.1 → v2.14.0
window and triggers the signed-tag release.

### Highlights since v2.13.1

- **`agentic-workflows` reference** documenting `gh-aw` and `awf`
workflow-as-prompt tooling for autonomous GitHub Actions — new patterns
for running AI agents on PRs/issues without bespoke wiring
([#75](#75)).
- **AI reviewer pushback patterns** — handling Copilot/Sourcery review
comments that disagree with the codebase intent, including when to defer
and when to push back
([#66](#66),
[#74](#74)).
- **PR-merge / branch-protection / CodeQL gotchas** documented, plus
auto-detection of allowed merge strategy in the `--delete-branch`
snippet so the recipe doesn't break on repos with merge-commit-only
policies
([#69](#69),
[#71](#71),
[#72](#72)).
- **GraphQL `Repository.mergeQueue`** for queue detection — replaces a
brittle REST probe
([#70](#70)).
- **Assessment checkpoints overhaul**: new GH-34/GH-35/GH-36,
follow_uses delegation for CodeQL/Scorecard, org_provides for
community-health files, broader licence/Dependabot/workflow targets,
plus reusable-workflow-pitfalls reference. Multiple false-positive
findings demoted to `info` to reduce assessment noise
([#56](#56),
[#57](#57),
[#58](#58),
[#59](#59),
[#60](#60),
[#61](#61),
[#62](#62),
[#63](#63),
[#64](#64),
[#65](#65),
[#73](#73)).
- **npm distribution** — the skill now also ships via
`@netresearch/agent-skill-coordinator`
([#54](#54),
[#55](#55)).
- **Release pipeline hardening** — dropped the deprecated `with: bump:`
block + `workflow_dispatch.bump` input so releases happen exclusively
via locally-signed tags, plus SLSA-provenance permissions on the caller
([#52](#52),
[#53](#53)).

### Release plan

After merge: tag main with a signed annotated tag, push, the
`skill-repo-skill` reusable workflow publishes archives + SHA256SUMS
with cosign + SLSA attestation, then narrative notes get applied via `gh
release edit ... --notes-file`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants