From 63bb979a9684e0ee7bf147e6703b6a816eb4c431 Mon Sep 17 00:00:00 2001 From: Sebastian Mendel Date: Tue, 21 Apr 2026 19:48:39 +0200 Subject: [PATCH] fix(refs): address Copilot second-sweep findings from #56 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - merge-strategy.md: error message now says 'review request(s) (user/team)' instead of 'requested reviewer(s)' so the output matches the code path that counts both users and teams - auto-merge-guide.md: add a pagination note — reviewThreads(first: 100) hits GitHub's per-page maximum but very large PRs can exceed it; point at pageInfo cursor pagination for the edge case Threads: PRRT_kwDOQoDmGs58lGOt, PRRT_kwDOQoDmGs58lGPA Signed-off-by: Sebastian Mendel --- skills/github-project/references/auto-merge-guide.md | 2 ++ skills/github-project/references/merge-strategy.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/skills/github-project/references/auto-merge-guide.md b/skills/github-project/references/auto-merge-guide.md index f26c7f5..959494f 100644 --- a/skills/github-project/references/auto-merge-guide.md +++ b/skills/github-project/references/auto-merge-guide.md @@ -111,6 +111,8 @@ for pr in "${prs[@]}"; do done ``` +`reviewThreads(first: 100)` covers GitHub's per-page maximum. Paginate with `pageInfo { hasNextPage endCursor }` + `after:` for PRs that might exceed 100 threads (long-running PRs on hot files). + For each unresolved thread: 1. Read the initial comment body via `reviewThreads(first: 100) { nodes { id isResolved comments(first: 1) { nodes { author { login } body } } } }`. Bump `comments(first:)` or paginate if you need follow-up replies on the same thread rather than just the initiating comment. diff --git a/skills/github-project/references/merge-strategy.md b/skills/github-project/references/merge-strategy.md index d079032..cf5731b 100644 --- a/skills/github-project/references/merge-strategy.md +++ b/skills/github-project/references/merge-strategy.md @@ -180,7 +180,7 @@ If you need to hold merge until Copilot (or any other requested reviewer) has ac pending=$(gh api "repos/$REPO/pulls/$PR" \ --jq '((.requested_reviewers // []) | length) + ((.requested_teams // []) | length)') if [[ "$pending" -gt 0 ]]; then - echo "::error::Still waiting on $pending requested reviewer(s)" + echo "::error::Still waiting on $pending review request(s) (user/team)" exit 1 fi ```