feat: modernize fork with panic fixes, DST handling, and CI #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug robfig#554/robfig#555: TZ= parsing panic - Added bounds check for space index in timezone parsing - Returns error instead of panicking when spec has no fields after timezone - Added comprehensive tests for malformed timezone specs Bug robfig#551: Entry.Job.Run() bypasses chain decorators - Added Entry.Run() method that executes through WrappedJob - Ensures SkipIfStillRunning, DelayIfStillRunning, Recover are respected - Added tests validating chain behavior Tests: All new panic-prevention tests pass
- Updated go.mod from Go 1.12 to Go 1.25 - Changed module path from github.com/robfig/cron/v3 to github.com/netresearch/cron - Fresh start with v1 versioning (no /v3 suffix) - All tests pass with new Go version
Based on multi-model consensus (9/10 confidence), the repository has been renamed from 'gron' to 'go-cron' following Go ecosystem naming conventions (go-redis, go-github, etc.).
When time jumps forward due to DST (e.g., 2am→3am), jobs scheduled during the skipped hour now run immediately at the next valid time instead of being skipped entirely. This follows ISC cron behavior and fixes common user expectations. Based on robfig/cron PR robfig#541.
- Update badges and import paths for the fork - Document panic fixes (issues robfig#554, robfig#555, robfig#551) - Document DST handling improvements (PR robfig#541) - Update Go version requirement to 1.25 - Simplify and modernize documentation structure
- Add comprehensive CI workflow with tests, linting, security scans - Add Dependabot for gomod and github-actions updates - Add golangci-lint v2 configuration with staticcheck, govet - Fix deprecated io/ioutil usage (replace with io package) - Apply gofmt/gofumpt/gci formatting across codebase - Disable S1000/S1037 staticcheck rules for test patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the robfig/cron fork with critical fixes and improvements:
Bug Fixes
Entry.Run()when WrappedJob is nilEnhancements
github.com/netresearch/go-cronCI/Quality
io/ioutilusageDocumentation
Test plan