Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing Panel in Debug Bar: Call to undefined method RouteList::getModule() #264

Closed
Thommas2316 opened this issue Jul 11, 2020 · 2 comments

Comments

@Thommas2316
Copy link

Thommas2316 commented Jul 11, 2020

Version: 3.0.5

Bug Description

Hi,

after updating to 3.0.5, the DebugBar shows an error about RouteList not having method getModule().
After some investigation the problem seems to be with the transition from Application\Routers* classes to Nette\Routing* (mentioned in release notes for 3.0.5), as the RouteList in nette/application has the method, but the one in nette/routing does not.

This line seems to be the culprit:

$this->analyse($subRouter, $module . $router->getModule(), $parentMatches, $level + 1);

The $router in this section is instance of \Nette\Routing\RouteList instead of \Nette\Application\Routers\RouteList (which has the mentioned method available).

Here is the screen from DebugBar :
image

When downgraded to 3.0.4 everything works as expected.

Steps To Reproduce

Upgrade to nette/application:3.0.5

Expected Behavior

Working routing panel

Possible Solution

Porting module functionality to RouteList in nette/routing ?

P.S.: Sorry for not sending the pull request with the fix, as I know the line which is buggy, but I don't know the concept behind the transition so I'm not able to fix it (at the moment) :/

@dg
Copy link
Member

dg commented Jul 12, 2020

Should be fixed, can you check it?

@Thommas2316
Copy link
Author

Thommas2316 commented Jul 13, 2020

Problem solved.

Thank you for such a quick fix and have a nice rest of the day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants