Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break in patch version: Component::link() signature #298

Closed
xificurk opened this issue Oct 15, 2021 · 0 comments
Closed

BC break in patch version: Component::link() signature #298

xificurk opened this issue Oct 15, 2021 · 0 comments

Comments

@xificurk
Copy link
Contributor

xificurk commented Oct 15, 2021

Version: 3.1.4

Bug Description

Version 3.1.4 changed the signature of Component::link() (use variadic parameter). This is a BC break affecting anyone overriding the method or using any library that does so (e.g. nextras/secured-links).

Steps To Reproduce

Upgrade nette/application to v3.1.4 in any project using nextras/secured-links and try to run the app.

Expected Behavior

App runs :)

Actual Behavior

Fatal error: Declaration of Nextras\Application\UI\SecuredLinksControlTrait::link(string $destination, $args = []): string must be compatible with Nette\Application\UI\Component::link(string $destination, ...$args): string

Possible Solution

Revert the method signature change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants