FileResponse: send response either as attachment or inline #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +33,9 @@ class FileResponse extends Nette\Object implements Nette\Application\IResponse | |||
| /** @var bool */ | |||
| public $resuming = TRUE; | |||
|
|
|||
| /** @var bool */ | |||
| private $contentDispositionAttachment = TRUE; | |||
There was a problem hiding this comment.
What an ugly name, $isAttachment? Or maybe better $forceDownload?
|
I would add it as 4th constructor parameter as well, defaulting to TRUE and remove setter. |
| */ | ||
| public function setContentDispositionAttachment($attachment = TRUE) | ||
| { | ||
| return $this->contentDispositionAttachment = $attachment; |
There was a problem hiding this comment.
Setters in Nette usually return $this so they provide fluent behavior.
FileResponse: send response either as attachment or inline FileResponse: send response either as attachment or inline FileResponse: send response as attachment or inline
|
Guys thanks a lot for your feedback! I followed the contribution guide, changed the code and forced-pushed changes here. The only problem I see is the missing line at the end of the file with tests. I can see it in my local version. I will check the settings of git, maybe it is cutting them? Or do you have any ideas? |
dg
added a commit
that referenced
this issue
Jun 2, 2014
FileResponse: send response either as attachment or inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This pull requests allows files in response being sent directly into browser instead of forcing them to be downloaded - this is especially helpful when there is a need to show e.g. pdf files directly in the browser window. See related issue nette/nette#1410.
As proposed in the contribution guide http://nette.org/en/contributing, I am adding following information:
I am really a newbie. I will appreciate if you provide me with some explaining comments in case you find this pull request as not acceptable. Thanks a lot!