Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Added possibility to configure PresenterFactory mapping via array #119

Closed
wants to merge 1 commit into from

Conversation

@petrhejna
Copy link

petrhejna commented Feb 14, 2016

BC break: no
Documentation: needed

Solves: #101

@petrhejna

This comment has been minimized.

Copy link
Author

petrhejna commented Feb 14, 2016

(Still in progress.)

I realize this must be written differentlly, Parts of array must be validated and this must be allowed:

$factory->setMapping([
    '*' => ['App\\', '*'],
]);
Assert::same('App\RedDwarf', $factory->formatPresenterClass('RedDwarf'));
@petrhejna

This comment has been minimized.

Copy link
Author

petrhejna commented Feb 15, 2016

Ok, there is a proof of concept solution (I moved from red to greeen). Plase give me some feedback if I didn't miss any case or if there any missing functionality.

Then I'll do some code cleaning & refactoring. I would like to extract the logic of parsing into some "PresenterMappingParser".

@petrhejna petrhejna changed the title Added possibility to configure PresenterFactory mapping via array [RFC] Added possibility to configure PresenterFactory mapping via array Feb 15, 2016
@milo

This comment has been minimized.

Copy link
Member

milo commented Mar 29, 2016

Ref #101

@matej21

This comment has been minimized.

Copy link
Contributor

matej21 commented Mar 30, 2016

@Achse can you please simplify this? is an array with 1 and 2 items really necessary? I think the version with 3 items is sufficient.

@petrhejna

This comment has been minimized.

Copy link
Author

petrhejna commented Mar 31, 2016

I am very busy right now. Please, anyone is free to fork my PR and finish it or write it from scratch. Just tell here, to prevent simultanous work. I dont know when I get time to finish this.

@dg dg closed this in fa3ba64 Apr 1, 2016
dg added a commit that referenced this pull request Apr 3, 2016
dg added a commit that referenced this pull request Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.