Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on nette/security #132

Merged
merged 1 commit into from May 3, 2016
Merged

Remove dependency on nette/security #132

merged 1 commit into from May 3, 2016

Conversation

@enumag
Copy link
Contributor

enumag commented May 1, 2016

As far as I can tell nette/security seems to be optional everywhere in nette/application.

@dg

This comment has been minimized.

Copy link
Member

dg commented May 2, 2016

Can you change commit message to smthng like composer: removed …?

@enumag enumag force-pushed the enumag:security branch from 371f629 to 4df3530 May 2, 2016
@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented May 2, 2016

@dg Done.

@dg

This comment has been minimized.

Copy link
Member

dg commented May 2, 2016

Btw it is required by storeRequest() & restoreRequest()

@enumag enumag force-pushed the enumag:security branch from 4df3530 to 5aa7a2b May 2, 2016
@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented May 2, 2016

@dg Added some conditions to make them work without user.

@dg

This comment has been minimized.

Copy link
Member

dg commented May 2, 2016

Did you test it?

@enumag enumag force-pushed the enumag:security branch from 5aa7a2b to c92337d May 2, 2016
@enumag

This comment has been minimized.

Copy link
Contributor Author

enumag commented May 2, 2016

Oh right... can't use getUser because it throws an exception... Added a test for storeRequest as well. There are no existing tests for restoreRequest.

Can't really test it in a real application though. I use my own implementation of these methods to make them work with object parameters.

@dg dg force-pushed the nette:master branch from 935b6d4 to f0b5ac0 May 2, 2016
@Majkl578

This comment has been minimized.

Copy link
Contributor

Majkl578 commented May 3, 2016

Needs rebase after force-pushes... :(

@dg dg force-pushed the nette:master branch from f0b5ac0 to 935b6d4 May 3, 2016
@dg dg merged commit bc2dfc2 into nette:master May 3, 2016
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.1%) to 78.167%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dg added a commit that referenced this pull request May 3, 2016
dg added a commit that referenced this pull request May 3, 2016
@dg

This comment has been minimized.

Copy link
Member

dg commented May 3, 2016

Thanks, merged

@@ -1080,7 +1080,7 @@ public function storeRequest($expiration = '+ 10 minutes')
$key = Nette\Utils\Random::generate(5);
} while (isset($session[$key]));

$session[$key] = [$this->getUser()->getId(), $this->request];
$session[$key] = [$this->user ? $this->user->getId() : null, $this->request];

This comment has been minimized.

Copy link
@lookyman

This comment has been minimized.

Copy link
@enumag

enumag May 3, 2016

Author Contributor

Yeah, @dg already fixed that when he merged it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.