Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenter: fixed creating link with required persistent parameters #148

Merged

Conversation

@JanTvrdik
Copy link
Contributor

JanTvrdik commented Jul 27, 2016

No description provided.

UI\Presenter::argsToParams($class, $method, $params);
UI\Presenter::argsToParams($class, $method, $params, [], $missing);
if ($missing) {
$argName = key($missing);

This comment has been minimized.

Copy link
@dg

dg Jul 27, 2016

Member

This can be shorten to list($argName, $rm) = each($missing)

@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 27, 2016

👍

@dg dg merged commit d6b1ed5 into nette:master Jul 27, 2016
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.007%) to 76.702%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JanTvrdik JanTvrdik deleted the JanTvrdik:pr/fix_missing_args_filled_from_persistent branch Jul 27, 2016
dg added a commit that referenced this pull request Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.