Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize $since variable #166

Closed
wants to merge 1 commit into from
Closed

Conversation

@lukascellar
Copy link

lukascellar commented Nov 29, 2016

Variable $since at line 1172 is undefined and causes PHP Notice.

Variable $since at line 1172 is undefined and causes PHP Notice.
@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 1, 2016

This should never happen (line 1164). What's your structure components?

@dg dg force-pushed the nette:master branch 4 times, most recently from 7447ad4 to 3165d3a Dec 20, 2016
@dg dg force-pushed the nette:master branch 4 times, most recently from 3fb5d4a to d2e3dc1 Jan 2, 2017
@dg dg force-pushed the nette:master branch 11 times, most recently from 07d4ebb to 337c67c Jan 14, 2017
@dg dg force-pushed the nette:master branch 9 times, most recently from 7c8af57 to ec7d92a Jan 25, 2017
@dg dg force-pushed the nette:master branch 15 times, most recently from d186075 to 4fedb44 Jan 25, 2017
@dg dg force-pushed the nette:master branch from 88ef0bd to b7df270 Feb 2, 2017
@dg dg force-pushed the nette:master branch from e6b9262 to af754ba Feb 9, 2017
@TomasVotruba

This comment has been minimized.

Copy link

TomasVotruba commented Apr 12, 2017

@lukascellar Could you provide more details?

@lukascellar

This comment has been minimized.

Copy link
Author

lukascellar commented Apr 12, 2017

It occurs in dashboard of my application, some dashboard controls are registered dynamically in DI extension (modular application, module can add component to dashboard).

/admin?dashboard-todoControl-todoGrid-id=472&do=dashboard-todoControl-todoGrid-solve

	public function beforeCompile()
	{
		$builder = $this->getContainerBuilder();

		/**
		 * Install to dashboard
		 */
		foreach ($builder->findByType(DashboardPresenter::class) as $dashboardPresenterDefinition) {
			$dashboardPresenterDefinition
				->addSetup(new Statement('$service->getComponent(\'dashboard\')->addComponent(?, ?)', [
					new Statement('@' . $this->prefix('todoControlFactory') . '::create'),
					'todoControl'
				]))
				->addSetup('$service->getComponent(\'dashboard\')->getComponent(\'todoControl\')->addFilterHideSolved(?)', [true]);
		}
	}
@dg dg closed this in 66cd441 Apr 12, 2017
dg added a commit that referenced this pull request Apr 12, 2017
@TomasVotruba

This comment has been minimized.

Copy link

TomasVotruba commented Apr 12, 2017

Thank you Lukáši for nice report.

And you Davide for fast fixup!

@dg

This comment has been minimized.

Copy link
Member

dg commented Apr 12, 2017

@lukascellar lukascellar deleted the lukascellar:patch-1 branch Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.