Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route::constructUrl(): split of module and presenter moved before global filter #167

Merged
merged 1 commit into from Dec 10, 2016

Conversation

@vlastavesely
Copy link
Contributor

vlastavesely commented Dec 10, 2016

I was doing some changes in structure of my application and I have found something what is IMHO bug.

In short: right now, the global input filter gets module and presenter split (like this: [Module: 'Front', Presenter: 'Homepage']) but output filter gets them together as presenter ([Presenter: 'Front:Homepage']).

Wouldn't it be better to unify the behaviour of those two functions to get the params split in both cases?

@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 10, 2016

Makes sense, thanks.

@dg dg merged commit bdf16da into nette:master Dec 10, 2016
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.01%) to 77.546%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlastavesely vlastavesely deleted the vlastavesely:split_module_presenter branch May 24, 2017
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.