New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control: enhanced code completion for $template #184

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
2 participants
@dg
Member

dg commented Aug 7, 2017

  • bug fix? no
  • new feature? yes
  • BC break? no

Pros:

  • Improves code completion in PhpStorm.

Cons:

  • stdClass is here just as workaround for specific editor
  • Nette\Bridges\ApplicationLatte\Template is simply not true

image

@TomasVotruba

This comment has been minimized.

Show comment
Hide comment
@TomasVotruba

TomasVotruba Aug 9, 2017

Member

Awesome, go for it!

Member

TomasVotruba commented Aug 9, 2017

Awesome, go for it!

@dg dg merged commit 91e93d0 into nette:master Aug 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 80.277%
Details

@dg dg deleted the dg:pull-cc branch Aug 9, 2017

dg added a commit that referenced this pull request Aug 9, 2017

@TomasVotruba

This comment has been minimized.

Show comment
Hide comment
@TomasVotruba
Member

TomasVotruba commented Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment