Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Route inflectors visibility to public #192

Merged
merged 1 commit into from Mar 7, 2018

Conversation

@dakorpar
Copy link
Contributor

dakorpar commented Mar 3, 2018

  • bug fix? no
  • new feature? no
  • BC break? no
  • doc PR: nette/docs

THis just makes inflectors methods inside routes public. I bumped already in two project that I needed this code when developing some custom routes, and I think others also. In any way can't find anything harmful in this. Was also thinking to extract those methods maybe to RoutingHelper or something like that...

@dg dg merged commit b2bddee into nette:master Mar 7, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 80.553%
Details
dg added a commit that referenced this pull request Mar 7, 2018
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 3, 2019
dg added a commit to nette/routing that referenced this pull request Feb 10, 2019
dg added a commit to nette/routing that referenced this pull request Feb 20, 2019
dg added a commit to nette/routing that referenced this pull request Feb 20, 2019
dg added a commit to nette/routing that referenced this pull request Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.