Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upChanged redirect() docs to support correct use-case #221
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mabar commentedJun 17, 2019
Helpful for static analysis like with phpstan - calls with deprecated
int $codeget reported while calls with destination and arguments only are considered valid.Current behavior unfortunatelly support only calls with int $code and every up-to-date application needs to ignore phpstan errors with pattern like this
'#^Parameter \#2 \$destination of method Nette\\Application\\UI\\Component\:\:redirect\(\) expects string\|null, array.+given\.$#'