Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenter: injectPrimary() params are required because $httpRequest is required #239

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Dec 2, 2019

  • new feature?
  • BC break? no

Mark optional parameters as required (without = null), because parameter $httpRequest is required.

Removed set default value as null, because in real code user must define value. Only marked as nullable.

…s required.
@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 3, 2019

Thanks

@dg dg merged commit f505669 into nette:master Dec 3, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
dg added a commit that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.