Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Presenter::createRequest non-final #262

Closed
wants to merge 25 commits into from

Conversation

dakujem
Copy link

@dakujem dakujem commented May 28, 2020

  • BC break? no

Summary
Make Presenter::createRequest() method non-final.
Furthermore, inside Presenter::createRequest() call static::argsToParams() instead of self::argsToParams() to allow for extension.

Rationale
The rationale behind the change is simple: allow for extension of link creation.
For well over 6 years, since 2.0.14, it has been non-final, and now it is final in 3.0 again. It was final in 2.0.*, then made non-final in 2.0.14 just half a year later. It was final in 0.* versions, but those were deep medieval ages.

Use cases
I now have two use cases that require the method's extension.

  • custom link logic for which i found a workaround (not an ellegant one)
  • and now I am unable to implement method injection because of links requiring all action* method's arguments being passed.

Thank you for considering this.

@dakujem
Copy link
Author

dakujem commented Jul 3, 2020

bump

dg and others added 22 commits July 12, 2020 20:52
Automatically will register methods as latte custom functions
@dg dg force-pushed the master branch 2 times, most recently from 806cba6 to 2c9e9d2 Compare July 12, 2020 19:12
@dg dg force-pushed the master branch 2 times, most recently from ea5ac15 to 0e37ebd Compare November 16, 2020 01:42
@dg dg force-pushed the master branch 2 times, most recently from af99b74 to ad60129 Compare November 25, 2020 18:17
@dg dg force-pushed the master branch 3 times, most recently from cfac883 to 45d9ace Compare December 17, 2020 22:27
@dg dg force-pushed the master branch 5 times, most recently from 3fb89c6 to fcb2578 Compare December 31, 2020 18:40
@dg dg force-pushed the master branch 3 times, most recently from 3c5786c to f84c16a Compare January 22, 2021 16:42
@dg dg force-pushed the master branch 5 times, most recently from 13f5ab3 to c15bd94 Compare January 26, 2021 21:24
@dg dg force-pushed the master branch 3 times, most recently from b3dcfb1 to de09883 Compare February 4, 2021 03:57
@dg dg closed this in e34638a Feb 5, 2021
dg added a commit that referenced this pull request Feb 5, 2021
dg added a commit that referenced this pull request Feb 5, 2021
@dakujem
Copy link
Author

dakujem commented Feb 7, 2021

Finally, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants