Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatteExtension: inject interface to be more compatible #288

Merged
merged 1 commit into from May 26, 2021

Conversation

milo
Copy link
Member

@milo milo commented May 21, 2021

I hit the #287 too. After Latte upgrade and with my own UI\TemplateFactory implementation in DI (with ApplicationLatte\TemplateFactory autowiring off) container buid fails.

I thik this fix will work but it's a pitty that one lost new great latte panel. So it is more or less hotfix. Maybe to find another way how to hook the panel to template, maybe via decorator, but I'm sure how to do it.

@milo milo changed the title LatteExtension: inject interface to be more compatible (#287) LatteExtension: inject interface to be more compatible May 21, 2021
@dg
Copy link
Member

dg commented May 26, 2021

Thanks

@dg dg merged commit 11bc5ae into nette:master May 26, 2021
@dakujem
Copy link

dakujem commented May 26, 2021

@dg Could you please merge this into the v3.1 branch too?

dg pushed a commit that referenced this pull request Jun 1, 2021
Co-authored-by: Miloslav Hůla <miloslav.hula@fsv.cvut.cz>
dg pushed a commit that referenced this pull request Jun 2, 2021
Co-authored-by: Miloslav Hůla <miloslav.hula@fsv.cvut.cz>
dg pushed a commit that referenced this pull request Jun 2, 2021
Co-authored-by: Miloslav Hůla <miloslav.hula@fsv.cvut.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use custom TemplateFactory with LatteExtension since 3.1
3 participants