Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenter: removed static from refUrl variable #80

Merged
merged 1 commit into from Jul 28, 2016

Conversation

@Yrwein
Copy link
Contributor

Yrwein commented Jun 12, 2015

  • bugfix
  • documentation - not needed
  • BC break - no

The pull request fixes issue when testing presenters without isolation: You make two presenter calls with Nette\Http\Request-s on different domains - the first domain is cached for whole class (and not only instance) and so the second instance of the same presenter will redirect you to the first domain.
The test is appended mainly as example (there's no problem to remove it if it's not needed).

@Yrwein Yrwein force-pushed the nubium:remove_static_from_refUrl branch from bb63d7c to fb53532 Jun 12, 2015
@fprochazka

This comment has been minimized.

Copy link
Contributor

fprochazka commented Jun 12, 2015

👍 I like it. But how does it affect performance in real-world apps?

@Yrwein

This comment has been minimized.

Copy link
Contributor Author

Yrwein commented Jun 15, 2015

Frankly, I don't think there will be measurable performance hit from changing function's static variable to property. Or is there something I'm missing? (Nevertheless we can wait few weeks until it's deployed.)

@dg dg force-pushed the nette:master branch 6 times, most recently from 51b53ed to d36f845 Jun 18, 2015
@dg dg force-pushed the nette:master branch 3 times, most recently from 0c73a68 to d07d7b3 Jul 1, 2015
@dg dg force-pushed the nette:master branch from 9a2b7f6 to 996644b Jul 11, 2015
@dg dg force-pushed the nette:master branch 5 times, most recently from 8e097dc to e4eb640 Sep 30, 2015
@dg dg force-pushed the nette:master branch from 4e0af51 to 8d1573a Nov 25, 2015
@dg dg force-pushed the nette:master branch 2 times, most recently from 7f051bf to f87df33 Dec 2, 2015
@dg dg force-pushed the nette:master branch 2 times, most recently from 9725b1d to 9869e52 Jan 13, 2016
@dg dg force-pushed the nette:master branch 4 times, most recently from 18f376d to 3fe619f Jan 22, 2016
@dg dg force-pushed the nette:master branch 2 times, most recently from 20a93ca to 08cbdeb Feb 8, 2016
@dg dg force-pushed the nette:master branch 8 times, most recently from e9c215d to 99249bf Apr 30, 2016
@dg dg force-pushed the nette:master branch 5 times, most recently from b7a311f to eba19f3 May 9, 2016
@dg dg force-pushed the nette:master branch 6 times, most recently from 7b1ec30 to 3adfa43 May 17, 2016
@dg dg force-pushed the nette:master branch 4 times, most recently from c73b255 to 9e7cd60 Jun 1, 2016
@dg dg force-pushed the nette:master branch 2 times, most recently from ea11e9d to 8ff194f Jun 14, 2016
@rostenkowski

This comment has been minimized.

Copy link

rostenkowski commented Jul 28, 2016

Hi there:)

what's the current status of this pull request?

@dg dg merged commit 2c86258 into nette:master Jul 28, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dg added a commit that referenced this pull request Jul 28, 2016
@rostenkowski

This comment has been minimized.

Copy link

rostenkowski commented Aug 4, 2016

Thank you
👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.