Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New container for each test #35

Closed
hrach opened this issue Feb 27, 2015 · 5 comments

Comments

@hrach
Copy link
Contributor

commented Feb 27, 2015

Due to this change 549fae0 a new Container is generated for each test file. Cointaner has different parameters -> different caching key.

@dg

This comment has been minimized.

Copy link
Member

commented Mar 4, 2015

Is it issue?

@fprochazka

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2015

Kind of. I certainly don't wanna generate new container for the same configuration, when it's compilation takes about 10 seconds. Fortunately, I'm setting the parameter manually, so I don't really care if this issue is resolved. Being it up to me I'd close it because there exists reasonable workaround.

@hrach

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2015

Dunno what is it good for. The point that there is workaround make this less important, but do not close the issue.

@fprochazka

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2015

The problem is that the dir is autodetected and you really have no way of reliable autodetection of this stuff from tests directory.

@fprochazka

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2015

nette/di#61 might solve this

@dg dg closed this in d4a1134 Jan 30, 2017

dg added a commit that referenced this issue Jan 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.