Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters added via addParameters() has higher priority (BC break) #56

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@dg
Copy link
Member

dg commented Mar 21, 2019

  • BC break? yes

Should have higher priority parameters defined in config file or added by addParameters()?

@solcik

This comment has been minimized.

Copy link

solcik commented Mar 21, 2019

For me config files are base and addParameters() should overwrite that.

@dg dg merged commit e1075af into nette:master Mar 26, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@dg dg deleted the dg:pull-priority branch Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.