Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileStorage: always creates directories #47

Merged
merged 1 commit into from Jan 29, 2017

Conversation

@dg
Copy link
Member

commented Oct 6, 2016

Problem with mkdir() and safe mode is outdated, isn't it?

@@ -27,6 +27,8 @@ public function __construct($tempDir)
public function loadConfiguration()
{
@mkdir($this->tempDir . '/cache'); // @ - directory may exists

This comment has been minimized.

Copy link
@fprochazka

fprochazka Oct 6, 2016

Contributor

Imho there should be a check for the return value and exception, no?

if (!@mkdir(...) && !is_dir(...)) throw

This comment has been minimized.

Copy link
@dg

dg Oct 6, 2016

Author Member

FileStorage will throw exception.

@dg dg force-pushed the nette:master branch 3 times, most recently from 492413c to b0b475e Jan 2, 2017

@dg dg force-pushed the nette:master branch 4 times, most recently from 6037e83 to 1fe69cc Jan 10, 2017

@dg dg force-pushed the nette:master branch 6 times, most recently from 1655c0f to 7c885a2 Jan 22, 2017

@dg dg force-pushed the dg:pull-dirs branch from 7f46e72 to 3c93e5d Jan 25, 2017

@dg dg force-pushed the nette:master branch 2 times, most recently from 0de58d2 to 29c60cc Jan 29, 2017

@dg dg force-pushed the dg:pull-dirs branch from 3c93e5d to 14a7078 Jan 29, 2017

@dg dg force-pushed the nette:master branch 2 times, most recently from 0c6a125 to 59da4eb Jan 29, 2017

@dg dg force-pushed the dg:pull-dirs branch from 14a7078 to 4d261dd Jan 29, 2017

@dg dg merged commit 92222cb into nette:master Jan 29, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@dg dg deleted the dg:pull-dirs branch Jan 29, 2017

dg added a commit that referenced this pull request Feb 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.