Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative message if name of unattached component is not available #5

Merged
merged 1 commit into from Jan 4, 2019
Merged

More informative message if name of unattached component is not available #5

merged 1 commit into from Jan 4, 2019

Conversation

mabar
Copy link
Contributor

@mabar mabar commented Jan 4, 2019

  • new feature
  • BC break? no
  • doc PR: not needed

Every single time I see component is not attached it is exactly Component '' is not attached to 'Nette\Application\UI\Presenter'..

...which component?

With proposed change it would at least inform about type of unattached component.
Component of type 'Foo\Bar\Baz' is not attached to 'Nette\Application\UI\Presenter'.

@dg
Copy link
Member

@dg dg commented Jan 4, 2019

Thanks

@dg dg merged commit 89dd693 into nette:master Jan 4, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants