Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upWrong type detection in PostgreSQL #163
Closed
Comments
This comment has been minimized.
This comment has been minimized.
|
Thank you @dg |
WyskyNet
pushed a commit
to trigama/nette-database
that referenced
this issue
May 30, 2018
WyskyNet
pushed a commit
to trigama/nette-database
that referenced
this issue
Jun 1, 2018
WyskyNet
pushed a commit
to trigama/nette-database
that referenced
this issue
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Data type detection does not accept all postgres supported timestamp types as "time" types. Here, postgres type "TIMESTAMP WITH TIME ZONE" is interpreted as string.
Steps To Reproduce
Create a table with two columns "TIMESTAMP" and "TIMESTAMP WITH TIME ZONE". Insert a record and compare the results in ActiveRow object -- the first column will be OK, the second will be string.
Fix is simple -- update Helpers.php as follows:
Changing the $typePatterns array on line with '(SMALL)?DATETIME(OFFSET)?\d*|TIME(STAMP)?' by adding .* after "STAMP".