Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance > It prevents multiple parse of query parts by regular expresions #131

Merged
merged 1 commit into from May 7, 2016

Conversation

@norbe
Copy link
Contributor

norbe commented May 5, 2016

I was debugging export of products becase it takes too much time. At blackfire.io I found that 20% of all time takes resolving cache keys. Problem was with repeated parsing of query parts with regular expressions, that is not necessary for getting cache key. This patch can saves lot of time if you working with large datasets...

@dg

This comment has been minimized.

Copy link
Member

dg commented May 7, 2016

Thanks

@dg dg merged commit 9d0723b into nette:master May 7, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 86.324%
Details
dg added a commit that referenced this pull request May 7, 2016
dg added a commit that referenced this pull request May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.