Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pgsql lastInserteId #145

Closed
wants to merge 4 commits into from
Closed

Fixed pgsql lastInserteId #145

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23d4b4f
Fixed pgsql lastInserteId
lulco Oct 15, 2016
e966899
Fixed quotes
lulco Oct 16, 2016
c497ccd
Return $data or ActiveRow also when primary key is not autoincrement
lulco Oct 18, 2016
6301f2b
Revert commit
lulco Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Database/Table/Selection.php
View file
Open in desktop
Expand Up @@ -821,7 +821,7 @@ public function insert($data)
? implode('.', array_map([$this->context->getConnection()->getSupplementalDriver(), 'delimite'], explode('.', $tmp)))
: NULL
);
if ($primaryKey === FALSE) {
if ($primaryKey === FALSE || $primaryKey === "0") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the string should be in single quotes, i.e. $primaryKey === '0'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, fixed

unset($this->refCache['referencing'][$this->getGeneralCacheKey()][$this->getSpecificCacheKey()]);
return $return->getRowCount();
}
Expand Down