Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlBuilder: method resetSelect #146

Merged
merged 2 commits into from Sep 30, 2018
Merged

SqlBuilder: method resetSelect #146

merged 2 commits into from Sep 30, 2018

Conversation

@EdaCZ
Copy link
Contributor

EdaCZ commented Nov 4, 2016

In one use case I need to reset select columns from SqlBuilder.

It's because when I get selection in my service I want to add some columns for grouping. But there are already set columns for select, so database don't allow to run this query - I get error Expression #1 of SELECT list is not in GROUP BY clause and contains nonaggregated column.

With this method I would simply reset select columns and It would be ok.

@dg dg force-pushed the nette:master branch 2 times, most recently from b74e9fb to b2e321a Dec 1, 2016
@dg dg force-pushed the nette:master branch from b2067a2 to a01c1e1 Dec 17, 2016
@dg dg force-pushed the nette:master branch 4 times, most recently from e249c62 to d56890f Jan 2, 2017
@dg dg force-pushed the nette:master branch 4 times, most recently from e95a595 to 0b4d2e5 Jan 15, 2017
@dg dg force-pushed the nette:master branch 18 times, most recently from d516a34 to daa14df Jan 24, 2017
@dg dg force-pushed the nette:master branch 6 times, most recently from f1a9aa2 to ec7a207 Jul 21, 2017
@dg dg force-pushed the nette:master branch 14 times, most recently from 1ea2fe2 to f4d7fc0 Mar 21, 2018
@dg dg force-pushed the nette:master branch from 0002802 to 0024c3b May 10, 2018
@dg dg force-pushed the nette:master branch from a888277 to 65a8029 Sep 13, 2018
@EdaCZ

This comment has been minimized.

Copy link
Contributor Author

EdaCZ commented Sep 29, 2018

@dg Hi, is there any problem with this PR?

@dg dg changed the base branch from master to v2.4 Sep 30, 2018
@dg

This comment has been minimized.

Copy link
Member

dg commented Sep 30, 2018

No problem, merged.

@dg dg merged commit c205f9c into nette:v2.4 Sep 30, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
dg added a commit that referenced this pull request Sep 30, 2018
@EdaCZ

This comment has been minimized.

Copy link
Contributor Author

EdaCZ commented Sep 30, 2018

@dg Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.