Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqliteDriver::getColumns() fix regexp for autoincrement recognition [Closes #164] #168

Merged
merged 1 commit into from May 18, 2017

Conversation

@clovnrian
Copy link
Contributor

clovnrian commented May 18, 2017

  • bug fix? Closes #164
  • new feature? no
  • BC break? no

Just fix the regular expression for finding autoincrement column in SQLite table.

I don't know if this is only SQLite 3.11.0 issue, but it uses "`" as quote character for column and table names, so autoincrement column definition looks like this:

id INTEGER NULL PRIMARY KEY AUTOINCREMENT

@dg dg merged commit 9a158d7 into nette:v2.4 May 18, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 86.459%
Details
@dg

This comment has been minimized.

Copy link
Member

dg commented May 18, 2017

Thanks

dg added a commit that referenced this pull request May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.