Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers::detectTypes() added support for TIMESTAMPZ #198

Merged
merged 1 commit into from Jun 1, 2018

Conversation

WyskyNet
Copy link

@WyskyNet WyskyNet commented May 30, 2018

…PostgreSQL [Closes #163]

(cherry picked from commit 6e4b22c)

  • bug fix / new feature? YES
  • BC break? NO

Hi,
we are using latest nette/database v2.4 with postgres and there is still bug with wrong detection of timestampz data type. Bug was fixed in master, but unfortunatelly not in current stable branch...

Is there possibility to merge this cherry pick to v2.4 branch?

@@ -10,6 +10,7 @@ CREATE TEMPORARY TABLE "types" (
"date" date NULL,
"time" time NULL,
"timestamp" timestamp NULL,
"timestampZone" timestamp with time zone NULL,
Copy link
Member

@dg dg May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add 'timestampZone' => null below etc.

Copy link
Author

@WyskyNet WyskyNet Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, all tests fixed

@dg
Copy link
Member

@dg dg commented Jun 1, 2018

Thanks!

@dg dg merged commit 5736260 into nette:v2.4 Jun 1, 2018
3 checks passed
@WyskyNet
Copy link
Author

@WyskyNet WyskyNet commented Jun 1, 2018

Can you create some tag for this release, please? For example 2.4.5.1? We can use it in composer 😄

@dg
Copy link
Member

@dg dg commented Jun 1, 2018

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants