Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers::detectTypes() added support for TIMESTAMPZ #198

Merged
merged 1 commit into from Jun 1, 2018

Conversation

@WyskyNet
Copy link

WyskyNet commented May 30, 2018

…PostgreSQL [Closes #163]

(cherry picked from commit 6e4b22c)

  • bug fix / new feature? YES
  • BC break? NO

Hi,
we are using latest nette/database v2.4 with postgres and there is still bug with wrong detection of timestampz data type. Bug was fixed in master, but unfortunatelly not in current stable branch...

Is there possibility to merge this cherry pick to v2.4 branch?

@@ -10,6 +10,7 @@ CREATE TEMPORARY TABLE "types" (
"date" date NULL,
"time" time NULL,
"timestamp" timestamp NULL,
"timestampZone" timestamp with time zone NULL,

This comment has been minimized.

Copy link
@dg

dg May 30, 2018

Member

add 'timestampZone' => null below etc.

This comment has been minimized.

Copy link
@WyskyNet

WyskyNet Jun 1, 2018

Author

Hi, all tests fixed

…PostgreSQL [Closes #163]

(cherry picked from commit 6e4b22c)
@WyskyNet WyskyNet force-pushed the trigama:v2.4.5-timestamp branch from 2c4c7fb to e4c6fda Jun 1, 2018
@dg

This comment has been minimized.

Copy link
Member

dg commented Jun 1, 2018

Thanks!

@dg dg merged commit 5736260 into nette:v2.4 Jun 1, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.456%
Details
@WyskyNet

This comment has been minimized.

Copy link
Author

WyskyNet commented Jun 1, 2018

Can you create some tag for this release, please? For example 2.4.5.1? We can use it in composer 😄

@dg

This comment has been minimized.

Copy link
Member

dg commented Jun 1, 2018

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.