Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SQL Clause in Where IS NOT NULL #226

Merged
merged 18 commits into from Apr 23, 2019
Merged

Implement SQL Clause in Where IS NOT NULL #226

merged 18 commits into from Apr 23, 2019

Conversation

@nargotik
Copy link
Contributor

nargotik commented Apr 12, 2019

  • new feature
  • BC break no
  • doc PR: nette/docs
Daniel added 2 commits Apr 12, 2019
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
Daniel
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
@dg

This comment has been minimized.

Copy link
Member

dg commented Apr 12, 2019

Please do not reopen new pull request, you can change code via force push.

Daniel
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
@nargotik

This comment has been minimized.

Copy link
Contributor Author

nargotik commented Apr 12, 2019

Sorry about it, i'm kinda noob in Git :)

Daniel added 2 commits Apr 12, 2019
Daniel
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
Daniel
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
@nargotik

This comment has been minimized.

Copy link
Contributor Author

nargotik commented Apr 22, 2019

Please do not reopen new pull request, you can change code via force push.

Have you view this implementation ?

@matej21

This comment has been minimized.

Copy link
Contributor

matej21 commented Apr 23, 2019

@nargotik test is still missing.
I think it should be enough if you modify this test:

test(function () use ($preprocessor) { // where

@nargotik

This comment has been minimized.

Copy link
Contributor Author

nargotik commented Apr 23, 2019

@nargotik test is still missing.
I think it should be enough if you modify this test:

database/tests/Database/SqlPreprocessor.phpt

Line 101 in 8b6230d

test(function () use ($preprocessor) { // where

Ok added, test

Failing test from coveralls mentions a file not changed at all :-)
Failing test appveyor is because of dns problem in getcomposer

@dg

This comment has been minimized.

Copy link
Member

dg commented Apr 23, 2019

Thanks!

@dg dg merged commit ff54cdc into nette:master Apr 23, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-0.4%) to 86.142%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dg added a commit that referenced this pull request Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.