Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDO, query with boolean parameters fails silently #231

Merged
merged 1 commit into from Jul 8, 2019
Merged

Conversation

@peldax
Copy link
Contributor

peldax commented May 2, 2019

  • bug fix
  • BC break? most likely not

Work around an PHP bug, where mysql query with boolean parameters and disabled emulated prepare-statements fails silently.
Bool value is interepreted incorrectly, more information in php bugtracker thread:

https://bugs.php.net/bug.php?id=38546

There is currently work being done in fixing the issue on the PHP end.

@peldax

This comment has been minimized.

Copy link
Contributor Author

peldax commented Jul 4, 2019

After 13 years, bug got fixed in PHP 7.3.7 !!

@dg

This comment has been minimized.

Copy link
Member

dg commented Jul 8, 2019

I hope it will not do problems in other databases.

@dg dg merged commit 3e1d1ea into nette:master Jul 8, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 86.142%
Details
dg added a commit that referenced this pull request Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.