ExtensionsExtension: added extension type checking (#209)

src/DI/Extensions/ExtensionsExtension.php

@@ -29,12 +29,14 @@ public function loadConfiguration()
 			if (is_int($name)) {
 				$name = null;
 			}
+			$args = [];
 			if ($class instanceof Nette\DI\Definitions\Statement) {
-				$rc = new \ReflectionClass($class->getEntity());
-				$this->compiler->addExtension($name, $rc->newInstanceArgs($class->arguments));
-			} else {
-				$this->compiler->addExtension($name, new $class);
+				[$class, $args] = [$class->getEntity(), $class->arguments];
 			}
+			if (!is_a($class, Nette\DI\CompilerExtension::class, true)) {
+				throw new Nette\DI\InvalidConfigurationException("Extension should be Nette\\DI\\CompilerExtension, '$class' given.");
+			}
+			$this->compiler->addExtension($name, (new \ReflectionClass($class))->newInstanceArgs($args));
 		}
 	}
 }

tests/DI/ExtensionsExtension.error.phpt

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+use Nette\DI;
+use Tester\Assert;
+
+
+require __DIR__ . '/../bootstrap.php';
+
+
+$compiler = new DI\Compiler;
+$compiler->addExtension('extensions', new Nette\DI\Extensions\ExtensionsExtension);
+
+Assert::exception(function () use ($compiler) {
+	createContainer($compiler, '
+	extensions:
+		foo: stdClass
+	');
+}, Nette\DI\InvalidConfigurationException::class, "Extension should be Nette\\DI\\CompilerExtension, 'stdClass' given.");