Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension - default config value is empty string #266

Closed
kravcik opened this issue Oct 1, 2021 · 0 comments
Closed

Extension - default config value is empty string #266

kravcik opened this issue Oct 1, 2021 · 0 comments

Comments

@kravcik
Copy link

kravcik commented Oct 1, 2021

Version: 3.0.10

Bug Description

Cannot send empty string, works in v3.0.9. Alternative null works in both versions.

Simplifiend code:

pf beforeCompile()
{
  $builder->getDefinitionByType(UserFormFactory::class)
    ->getResultDefinition()
    ->addSetup('setExpiration', ['']); // [null] works
}

image

Expected Behavior

Should be possible pass empty string. Or if this is intended, should throw exception and suggest null instead of ''.

@dg dg closed this as completed in 380d9bb Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant