Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: parseServices() and parseService() renamed to ??? [WIP] #112

Merged
merged 1 commit into from Jun 17, 2016

Conversation

@dg
Copy link
Member

dg commented May 22, 2016

It is named parseServices, because it parses 'service' in config, but it is public method and therefore should have more descriptive names. addDefinitions()? loadDefinitions()? loadDefinitionsFromConfig()?

@dg dg force-pushed the dg:parse-services branch from 2b1c152 to 60769de May 22, 2016
@dg dg force-pushed the nette:master branch from bf31539 to 6af1026 May 22, 2016
@dg dg force-pushed the dg:parse-services branch from 60769de to 7b9e115 May 22, 2016
@dg dg force-pushed the nette:master branch from 6af1026 to fb70434 May 23, 2016
@dg dg force-pushed the dg:parse-services branch from 7b9e115 to 617d88d May 23, 2016
@dg dg force-pushed the nette:master branch from fb70434 to a096ee8 May 23, 2016
@dg dg force-pushed the dg:parse-services branch from 617d88d to bcfb7ca May 23, 2016
@dg dg force-pushed the dg:parse-services branch from bcfb7ca to 6ef9652 Jun 7, 2016
@dg dg force-pushed the nette:master branch from 35135b1 to 5a200a5 Jun 7, 2016
@dg dg force-pushed the dg:parse-services branch from 6ef9652 to 97b3530 Jun 7, 2016
@f3l1x

This comment has been minimized.

Copy link
Member

f3l1x commented Jun 17, 2016

I like loadDefinitions().

…n() and loadDefinitions()
@dg dg force-pushed the dg:parse-services branch from 97b3530 to 71e06df Jun 17, 2016
@dg

This comment has been minimized.

Copy link
Member Author

dg commented Jun 17, 2016

@f3l1x ok

@dg dg merged commit 34f8df4 into nette:master Jun 17, 2016
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@dg dg deleted the dg:parse-services branch Jun 17, 2016
dg added a commit that referenced this pull request Jun 17, 2016
…n() and loadDefinitions() (#112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.