Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated factory: nullable types support #132

Closed
wants to merge 1 commit into from

Conversation

@matej21
Copy link
Contributor

matej21 commented Dec 21, 2016

No description provided.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 21, 2016

Coverage Status

Changes Unknown when pulling 63106a2 on matej21:feature/gen_factory_nullable into ** on nette:master**.

@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 21, 2016

@coveralls I have reported you as spam.

@TomasVotruba

This comment has been minimized.

Copy link
Contributor

TomasVotruba commented Dec 21, 2016

@dg What about using Scrutinizer? It doesn't spam and doesn't report false negative on test when coverage is decreased.

I use it on every project and I'm very happy with that.

@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 21, 2016

@matej21 it is not a correct solution, it will not work for example with function create(?string $title, ?Foo $foo, ?int $lorem = 1): Article;

@dg dg force-pushed the nette:master branch from 924732b to 198ce23 Dec 21, 2016
@dg dg closed this in e5cd7d3 Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.