Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceDefinition::setClass() parameter $args is deprecated (BC break) #146

Merged
merged 1 commit into from Aug 24, 2017

Conversation

dg
Copy link
Member

@dg dg commented Feb 27, 2017

  • bug fix? no
  • new feature? no
  • BC break? yes

class vs factory should be better distinguished, it is difficult to merge more configs where these options are mixed. Related to #39

@JanTvrdik
Copy link
Contributor

@JanTvrdik JanTvrdik commented Feb 27, 2017

@dg Is this BC break only for compiler extensions or for *.neon files as well?

@dg
Copy link
Member Author

@dg dg commented Feb 27, 2017

Only for direct usage of this method.

@dg dg force-pushed the master branch 2 times, most recently from 539908c to 9e31491 Compare Jul 12, 2017
@dg dg force-pushed the master branch 3 times, most recently from b1bf33b to abfbe74 Compare Jul 21, 2017
@dg dg merged commit c1de507 into nette:master Aug 24, 2017
1 check was pending
@dg dg deleted the pull-setclass branch Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants