Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceDefinition::setClass() parameter $args is deprecated (BC break) #146

Merged
merged 1 commit into from Aug 24, 2017

Conversation

@dg
Copy link
Member

commented Feb 27, 2017

  • bug fix? no
  • new feature? no
  • BC break? yes

class vs factory should be better distinguished, it is difficult to merge more configs where these options are mixed. Related to #39

@JanTvrdik

This comment has been minimized.

Copy link
Contributor

commented Feb 27, 2017

@dg Is this BC break only for compiler extensions or for *.neon files as well?

@dg

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2017

Only for direct usage of this method.

@dg dg force-pushed the nette:master branch 2 times, most recently from 539908c to 9e31491 Jul 11, 2017

@dg dg force-pushed the nette:master branch 3 times, most recently from b1bf33b to abfbe74 Jul 21, 2017

@dg dg force-pushed the dg:pull-setclass branch from 57e6ce7 to df163c4 Aug 24, 2017

@dg dg merged commit c1de507 into nette:master Aug 24, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@dg dg deleted the dg:pull-setclass branch Aug 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.