Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In case of malformed dependencies provide type hint for calling service #151

Merged
merged 1 commit into from Feb 19, 2018

Conversation

MilanPala
Copy link
Contributor

@MilanPala MilanPala commented Mar 23, 2017

  • bug fix? no
  • new feature? no
  • BC break? no

In case of malformed dependencies I got message such "Service '94': ...". Now I get "Service '94' (type of App\Presenter\HomePagePresenter): ..."

@dg dg force-pushed the master branch 2 times, most recently from 539908c to 9e31491 Compare Jul 12, 2017
@dg dg force-pushed the master branch 3 times, most recently from b1bf33b to abfbe74 Compare Jul 21, 2017
@dg dg force-pushed the master branch 5 times, most recently from 4243866 to e8187b3 Compare Aug 31, 2017
@f3l1x
Copy link
Member

@f3l1x f3l1x commented Feb 18, 2018

What do you think @dg about it? It would be fine merge it or reject it. I consider it useful. What about you?

@dg dg merged commit 401dca5 into nette:master Feb 19, 2018
2 checks passed
@MilanPala MilanPala deleted the type-hint branch Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants