Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader: add includes max nesting level #164

Closed
wants to merge 5 commits into from

Conversation

@trejjam
Copy link
Contributor

trejjam commented Feb 10, 2018

  • bug fix? yes
  • new feature? yes
  • BC break? no

Pull request for #162. Solving possible call stack overflow.

@trejjam trejjam force-pushed the Scalesoft:feature/loader-max-nesting branch 2 times, most recently from cd28d01 to 8bbb795 Feb 10, 2018
@trejjam

This comment has been minimized.

Copy link
Contributor Author

trejjam commented Feb 11, 2018

For code style error created issue nette/coding-standard#28

@dg

This comment has been minimized.

Copy link
Member

dg commented Feb 11, 2018

Does it make sense to include one file more than once (nested)? Ie. has sense to have INCLUDES_MAX_DEPTH larger than 1?

@trejjam

This comment has been minimized.

Copy link
Contributor Author

trejjam commented Feb 11, 2018

I was thinking about it and it is possible that someone use config like:

config.neon:

includes:
  - console.extension.neon
  - config.extensionRequiresConsole.neon

config.extensionRequiresConsole.neon:

extensions:
  vendor.name: Vendor\Name\DI\Extension
includes:
  - console.extension.neon

It is probably easy to remove this 'mess' from config, but I think it is basically not wrong.

@dg

This comment has been minimized.

Copy link
Member

dg commented Feb 11, 2018

I think it's better to add and remove files in the $loadedFiles and then only test the presence.

trejjam added 2 commits Feb 10, 2018
@trejjam trejjam force-pushed the Scalesoft:feature/loader-max-nesting branch from 4fbd76e to 5c0db20 Feb 11, 2018
@dg dg force-pushed the nette:master branch from 301c51b to 05e12bb Feb 11, 2018
@dg dg changed the base branch from master to v2.4 Mar 26, 2018
@dg dg changed the base branch from v2.4 to master Mar 26, 2018
@dg dg closed this in 2d0da64 Mar 26, 2018
dg added a commit that referenced this pull request Mar 26, 2018
dg added a commit that referenced this pull request Mar 26, 2018
dg added a commit that referenced this pull request Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.