Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhpGenerator: $name might not be defined #212

Merged
merged 2 commits into from Jul 19, 2019

Conversation

janbarasek
Copy link
Contributor

@janbarasek janbarasek commented Jul 18, 2019

  • bug fix
  • BC break? no

Solve:

 ------ -------------------------------------- 
  Line   DI/PhpGenerator.php                   
 ------ -------------------------------------- 
  99     Variable $name might not be defined.  
 ------ -------------------------------------- 

@f3l1x
Copy link
Member

@f3l1x f3l1x commented Jul 18, 2019

Hi. It is great you improving nette/di. I would suggest next time to join all changes to one PR, further codereview will be much easier.

@janbarasek
Copy link
Contributor Author

@janbarasek janbarasek commented Jul 18, 2019

@f3l1x I am very sorry for it. I thought it was better to check all the micro-fixations separate.

@dg
Copy link
Member

@dg dg commented Jul 19, 2019

Thanks

@dg dg merged commit f932c52 into nette:master Jul 19, 2019
2 checks passed
dg pushed a commit that referenced this issue Jul 19, 2019
* PhpGenerator: $name might not be defined
* ContainerPanel: elapsedTime can be float.
@dg
Copy link
Member

@dg dg commented Jul 19, 2019

thought it was better to check all the micro-fixations separate.

It is certainly better to do it as a separate comittes, but it can be in one PR. It could be more comfortable for you.

Sometimes I will join some commits when it is the same type of editing in different files etc…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants