Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolver: Fix undefined and never called spaces. #213

Merged
merged 2 commits into from Jul 19, 2019

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Jul 18, 2019

  • bug fix
  • BC break? no

Fix and basic reimplementation for define type hints in comment section and little code reorganization.

 ------ --------------------------------------------------------------------- 
  Line   DI/Resolver.php                                                      
 ------ --------------------------------------------------------------------- 
  117    Call to an undefined method ReflectionFunctionAbstract::isPublic().  
  117    Variable $refClass might not be defined.                             
  117    Variable $reflection might not be defined.                           
  118    Call to an undefined method ReflectionFunctionAbstract::isStatic().  
  118    Variable $reflection might not be defined.                           
  122    Variable $reflection might not be defined.                           
  124    Variable $reflection might not be defined.                           
  335    Negated boolean expression is always false.                          
 ------ --------------------------------------------------------------------- 
janbarasek added 2 commits Jul 18, 2019
@dg dg force-pushed the nette:master branch 4 times, most recently from ad26604 to a37036c Jul 19, 2019
@dg dg merged commit 89b7ae6 into nette:master Jul 19, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 93.151%
Details
dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
dg added a commit that referenced this pull request Jul 19, 2019
@janbarasek janbarasek deleted the janbarasek:janbarasek-resolver branch Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.