-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContainerLoader: simplify mutex handling #270
Conversation
Some prove that the lock was not released? |
You mean a unit test? |
I think the |
So the idea is: it is useless because the handle is stored in a local variable which frees the handle and the lock when the variable is going out of scope? |
Yeah, exactly. |
as discussed, I adjusted the PR to remove the UNLOCK line (and added a comment). |
Thanks |
This reverts commit 942e406. See nette/tracy#540
the code as was before this PR, did not release the file-mutex on e.g. one of theNette\IOException
throwing cases