Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Html:add() to Html:addHtml() to follow nette/utils#111 #120

Merged
merged 1 commit into from Jun 17, 2016

Conversation

@spaze
Copy link
Contributor

spaze commented May 20, 2016

nette/utils#111 has renamed Html::add() to Html::addHtml(), this is a followup pull request to use the new name in nette/forms

@hrach

This comment has been minimized.

Copy link
Contributor

hrach commented May 20, 2016

You will need to add proper constraits to composer.

@spaze

This comment has been minimized.

Copy link
Contributor Author

spaze commented May 20, 2016

Indeed, thanks @hrach. Dependencies need to be updated but I don't know how to do it before nette/utils#111 is merged in. Any idea?

@enumag

This comment has been minimized.

Copy link
Contributor

enumag commented May 20, 2016

If we assume that nette/utils#111 will be merged into Nette 2.4 before the first stable is released then there is no need to change composer.json - nette/forms already depends on nette/utils 2.4.

@dg dg merged commit aef9f3a into nette:master Jun 17, 2016
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage decreased (-3.9%) to 90.473%
Details
@spaze

This comment has been minimized.

Copy link
Contributor Author

spaze commented Jun 17, 2016

Thanks, @dg!

@dg

This comment has been minimized.

Copy link
Member

dg commented Jun 17, 2016

Thank you :)

dg added a commit that referenced this pull request Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.